Skip to content

feat: add session replay link api #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 21, 2024
Merged

feat: add session replay link api #445

merged 7 commits into from
Apr 21, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 20, 2024 •
edited
Loading

Description of the change

  1. Map OnSessionReplayLinkReady API that Retrieves the current session's replay link.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID = MOB-14010

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 20, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title feat: Mapping-Session-Replay-links-api feat: Mapping SessionReplay links api Feb 20, 2024
@mnoseir
Copy link

mnoseir commented Feb 20, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against 3699871

abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @ahmedAlaaInstabug 👍 ! Please check the suggestion I've added.

@ahmedAlaaInstabug @abdelhamid-f-nasser
Update CHANGELOG.md
3699871 
Co-authored-by: Abdelhamid Nasser <[email protected]>
@ahmedAlaaInstabug ahmedAlaaInstabug added the READY FOR MERGE Reviewed and ready for merge (after release request) label Mar 6, 2024
@a7medev a7medev changed the title feat: Mapping SessionReplay links api feat: add session replay link api Apr 17, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug merged commit ae1f238 into dev Apr 21, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/Mapping-Session-Replay-links-api branch April 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @mnoseir @abdelhamid-f-nasser