switch to pulse format if alsa format not available #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on some systems, for example on Fedora 26, the ffmpeg is compiled with the libalsa support disable.
improvements - in order to avoid to use the safe argument with the concat one - also, use formats to check the available formats in ffmpeg this seems a better way of doing it. Also this change includes some improvements in the code style.
|
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use this application on my laptop with Fedora26 installed. It so happens that the
ffmpegpackage that Fedora provides have thelibasound(alsa format) not enabled. Someone can do a custom build of the ffmpeg but that requires the user to be a superuser. Why just not using what is available?This commit is useful only for similar systems. So probably not worth to merge at this moment.