-
Notifications
You must be signed in to change notification settings - Fork 1
Replace Filter::equal and Filter::unequal with Filter::like and Filter::unlike correspondingly #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2b4734a to
ae75246
Compare
|
Since you're adjusting many usages of Consider the query The filter renderer/parser should handle this the same I think. If there's a wildcard, it can only be a This way the search bar and other components need to support all types. And can still use And don't forget the tests here 😉 |
2807647 to
4ef4b38
Compare
4ef4b38 to
8510953
Compare
nilmerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks, thanks so far! :)
…lter::unlike correspondingly
8510953 to
0557743
Compare
depends on Icinga/ipl-stdlib#33