Str::symmetricSplit(): Make $default only accept ?string
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After all, it is a Str-based class that should not pad anything other than string or null. see: https://github.com/Icinga/icingaweb2-module-businessprocess/actions/runs/8466543979/job/23195516401?pr=446
sukhwinder33445
force-pushed
the
fix-phpstan-errors
branch
from
b5f44a7 to
4964ed7
Compare
sukhwinder33445
changed the title
$default only accept ?string
nilmerg
approved these changes
Apr 22, 2024
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
At this time, there's no usage in neither repository's default branch of the Icinga organization, that defines the default not as string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all, it is a Str-based class that should not pad anything other than string or null.
see: https://github.com/Icinga/icingaweb2-module-businessprocess/actions/runs/8466543979/job/23195516401?pr=446