Remove button consistency

[martialblog]

Hi,

There are some inconsistencies with the remove buttons/confirmation pages in the "Access Control" and "Dashboard Settings".

First, the buttons to remove elements are different. X in the "Access Control" and a trash bin icon in the "Dashboard Settings".

Second, the confirmation pages after clicking the buttons are very inconsistent:

A very minor thing I know, but I bet @flourish86 has something so say about it.

[martialblog]

Other occurrences

Also, the X is not aligned in the Backends list:

[grupperino]

I would like to work on this issue if its possible :) I am a first time contributor and this seems like something well within in my capabilities...

[flourish86]

Thanks for your offer, @grupperino.

Since its functional so far, it only would make sense to make changes here, after we worked out a concept of how the ui could be improved here. At the moment we have higher priorities, though.

[martialblog]

Makes sense to have a concept first.

However, a quick and simple improvement would be to always use X (since there is only one use of the trash bin) and to normalize the buttons to use "Confirm Removal".

[nilmerg]

@grupperino If you're interested, several of our repositories on Github have labels indicating issues for beginners/newcomers, e.g. https://github.com/Icinga/icingaweb2/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22, maybe there's something that interests you.

[grupperino]

@nilmerg thanks for info I will take a look :)