-
Notifications
You must be signed in to change notification settings - Fork 25
ScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring
#167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ScheduleForm, TemplateForm, and TimeFrameForm Refactoring
yhabteab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's still being used though!
icingaweb2-module-reporting/library/Reporting/Web/Controller.php
Lines 12 to 19 in 1760080
| protected function redirectForm(Form $form, $url) | |
| { | |
| if ( | |
| $form->hasBeenSubmitted() | |
| && ((isset($form->valid) && $form->valid === true) | |
| || $form->isValid()) | |
| ) { | |
| $this->redirectNow($url); |
bca0436 to
d871ba4
Compare
ScheduleForm, TemplateForm, and TimeFrameForm RefactoringScheduleForm, TemplateForm, ReportForm, and TimeFrameForm Refactoring
eb50d97 to
2801c05
Compare
…()` as a static factory method
…omReport()` as a static factory method
…fromTemplate()` as a static factory method
…()` as a static factory method
|
@yhabteab Do you want to have a final look here? |
yhabteab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM as well! :)
This removes the Multiple Submit Buttons Hacks from
ScheduleForm,ReportForm,TemplateForm, andTimeFrameForm. it also adds PHPDocs and Typo annotation where possible.fixes #164