-
Notifications
You must be signed in to change notification settings - Fork 45
Redesign state badge widget on tiles #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb43418 to
af19f35
Compare
flourish86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, the original mockup still was done with the legacy theme.
Not sure, if it's just me. But compared to the mockups this doesn't look quite right, yet.
Here's a screenshot from how it looks in my Browser.
Could you please change the following:
- The Total count should be moved into the badge
- Please remove the dark transparent background
- The badges or badge groups
We should also combine handled and not-handled objects of the same state into a badge-group, like it has been done in the footer of the icingadb-web lists (e.g. Hosts).
We should also combine the badges by color (e.g. CRITICAL/DOWN) as this is otherwise hard to grasp, especially when there's many different badges.
Here's another mockup with the dark mode:
If you have any further questions, feel free to ask. 😊
6af4e49 to
655898c
Compare
3486e7a to
f07a189
Compare
82f0e6e to
74b4841
Compare
flourish86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the mentioned changes, otherwise it looks fine.👌 Thanks!
74b4841 to
4444733
Compare
flourish86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me. Thanks! 👍
4444733 to
a9ec1b7
Compare
nilmerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ensured compatibility with v2.10 now and cleaned up a bit. Note that Icinga/ipl-web#63 is required for this to work now.
Though, I believe some changes in the UI are not thought through enough:
- The total children count is placed at a weird location. The count belongs to the direct children. It's not the total of all states that are shown on the right. Best to be seen in the lower left tile. I think this confuses users an we'll get certainly reports that this number is too low. I think we should place the total count where it was previously.
- The OK states we're not shown previously. Now if there's everything green, like in the tiles below, they look somewhat off to me. I'd propose to not show them like before.
|
As discussed in our meeting, we should change the badges counts to the following:
This is how this would then for example look in the end. |
10760c9 to
f0b4e9d
Compare
Add and group state badges for acknowkedeged nodes based on state.
f0b4e9d to
464967b
Compare
464967b to
641b469
Compare
86e6b71 to
a45980a
Compare
a45980a to
d325844
Compare





resolves #303
requires Icinga/ipl-web#63