Add importOrderSafeSideEffects option
#240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbartho
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Great work. This is what I would have liked to see if we ever implemented this. I'm comfortable with the default being nothing, and the documentation is sufficiently verbose for now.
I recognize and mourn the "complexity" of adding an additional parameter, but I'm happy we're meeting more people's needs.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
This adds a new option,
importOrderSafeSideEffects, which is an array of regex patterns (similar toimportOrder) specifying side-effect-only imports which are considered "safe" to reorder along with the rest of imports.