Skip to content

Conversation

@razielgn
Copy link
Contributor

@razielgn razielgn commented May 4, 2022

Hello, this patch makes it possible to use the preferred way to authenticate pods with AWS STS (see here).
tl;dr without setting a keypair, but instead loading tokens from a mounted file handled by an admission controller.

I've tested it on our EKS deployment before submitting this PR.

@No9
Copy link
Collaborator

No9 commented May 4, 2022

Thanks very much for this contribution.
Happy to take the code but would you mind putting some info on the configuration into the chart readme below the eksctl section.
https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/README.md#eks-setup-for-gitops-pipelines-eksctl-or-similar
Also should there be an example values.yaml for it as well?
Something like https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/values.aws.yaml
and call it values.aws.sts.yaml

@razielgn
Copy link
Contributor Author

Sure, I've added a commit with more documentation and examples.

@No9
Copy link
Collaborator

No9 commented May 11, 2022

Great thanks for the update - I'll bundle and push a release towards the end of this week.

@razielgn
Copy link
Contributor Author

Awesome, thank you!

@No9 No9 merged commit d28569d into IBM:main May 20, 2022
@No9
Copy link
Collaborator

No9 commented May 21, 2022

merged and released in 8.4.0
Thanks again for this @razielgn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants