Update CDC tests to print out the stderr when tests fail #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
You're welcome. I'm away until Monday if the PR #116 isn't merged in by then I can rebase to that when I'm back |
No9
previously approved these changes
Nov 25, 2022
Collaborator
There was a problem hiding this comment.
Simple change so LGTM - @NKTomHaygarth Can you rebase and we will pull this in for the next release
Collaborator
|
Hey @NKTomHaygarth Just doing some house keeping. |
Contributor
Author
|
Hey @No9, sorry things got a little busy towards the end of last year so I had to shelve some of the stuff I was doing. I will look into rebasing this PR later this week and hopefully get it ready to merge in. |
Collaborator
|
No worries - thanks for coming back to it. |
Signed-off-by: Tom Haygarth <[email protected]>
NKTomHaygarth
force-pushed
the
feature/test_error_logs
branch
from
71d65ec to
10f54ba
Compare
No9
approved these changes
Mar 10, 2023
Collaborator
|
Thanks for following up on this @NKTomHaygarth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests for the Core Dump Composer the error output was not being printed. This was making things a little difficult to track down where the tests might be failing if the Composer was hitting an error path.
This PR just adds
println!("{}", String::from_utf8_lossy(&cdc.stderr));underneath all locations wherecdc.stdoutis already getting printed in the tests for the Composer