Skip to content

Conversation

@timbuchwaldt
Copy link
Collaborator

No description provided.

@No9
Copy link
Collaborator

No9 commented Oct 14, 2022

You've probably realized error! goes to std.err not std.out.
Don't forget to sign it so the DCO passes.
I want to get my patch to log4rs in the next release of CDH too estk/log4rs@1b988ed
so I'll publish this as soon as you're ready.

@timbuchwaldt
Copy link
Collaborator Author

Sorry about the dealy, there you go :)

@No9
Copy link
Collaborator

No9 commented Oct 19, 2022

Hey @timbuchwaldt The test for timeout is failing now. Can you take a look when you have a minute.

@No9
Copy link
Collaborator

No9 commented Jan 28, 2023

Hey @timbuchwaldt January house keeping :)
Is this still WIP or should we close it?

No special meaning here, just a random non-reserved exit-code.

Signed-off-by: Tim Buchwaldt <[email protected]>
@No9
Copy link
Collaborator

No9 commented Feb 20, 2023

Hey @timbuchwaldt - Thanks for coming back to this.
Do you want to land this now it's passing?

@No9 No9 merged commit 7ca8c61 into IBM:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants