Skip to content

Refactor error handling with thiserror #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Harui-i wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor error handling with thiserror #13

Harui-i wants to merge 2 commits into from

Conversation

@Harui-i
Copy link
Owner

@Harui-i Harui-i commented Dec 8, 2025

Summary

  • add thiserror dependency and introduce a unified BitbankUtilError type for API interactions
  • refactor response handling to map request errors and deserialization failures into structured errors
  • update public/private clients and order management to propagate the new error type
  • make public API tests skip gracefully when network transport is unavailable

Testing

  • cargo test public_ -- --nocapture

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Harui-i