-
Notifications
You must be signed in to change notification settings - Fork 137
File uploads - locally and on s3 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbadova
commented
Dec 6, 2021
kbadova
commented
Dec 6, 2021
f9fd393
to
67eec36
Compare
kbadova
commented
Dec 7, 2021
RadoRado
reviewed
Dec 13, 2021
ca69197
to
6f1f1fa
Compare
e65e50d
to
bc2cdfe
Compare
- All models shuuld have uuids as ids by default It is a matter of time we fix this in the styleguide
👀 |
- Using `django-storages`
RadoRado
reviewed
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a
files
Django app, which enables bothDIRECT
andPASS-THRU
upload scenarios, where the files can be uploaded bothLOCAL
and toS3
.The following combinations are possible:
Django admin
+DIRECT
+LOCAL
Django admin
+DIRECT
+S3
API
+DIRECT
+LOCAL
API
+DIRECT
+S3
API
+PASS-THRU
+LOCAL
API
+PASS-THRU
+S3
For the
PASS-THRU
, the API interface for the frontend remains the same - meaning, you don't need to write different code to handleLOCAL
vsS3
on the frontend.We can mix and match, depending on needs:
For frontend testing, there's a separate PR here - https://github.com/HackSoftware/Example-React-Project/pull/1
Settings
This PR introduces few new settings.
The file upload style & storage are controlled via:
Additionally, there are a bunch of AWS related settings, so
django-storages
andboto3
can do their job. They are located inconfig/settings/files_and_storages.py
Details
For S3 bucket configuration, you'll need the following CORS JSON:
Or if you know what you're doing with your bucket - configure it yourself 👌
Presigned data returned from S3 looks like this:
Resources