v1.2.2 #335
Merged
v1.2.2 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new types are to avoid mangling the current style implementation too much.
For now, custom themes will use constant structs like in Sniffnet's original code. Custom themes will be self contained instead of polluting the original code base. This should make it easier for contributors to modify or add any extra themes without having to change code in too many files.
I implemented a theme to ensure there are no compiliation issues. Floating point math can't be called from a const context, so the themes are returned from a non-const function for now. `iced::color!` is used for ergonomics.
* Support appending extra styles to the settings page AFTER the built in styles. * Make the whole thing scrollable.
`StyleType::Custom` should be serialized to and deserialized from a TOML table. The `toml` crate doesn't seem to figure this out which causes saving and loading the settings to fail. I fixed this by hinting that the type should be a table using serde's attributes.
…auth54 docs: add joshuamegnauth54 as a contributor for code, and design
Minimal custom themes implementation
|
@all-contributors please add @orhun for financial. |
|
I've put up a pull request to add @orhun! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release introduces aesthetic improvements (including new themes and color gradients), Finnish translation, migrates the app to Iced 0.10, and fixes various minor usability problems.
For more info see the CHANGELOG.