-
Notifications
You must be signed in to change notification settings - Fork 419
feat: add TLS support for mysql backend #6979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
commented
Sep 16, 2025
2d2d119
to
e6b2f0b
Compare
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
Signed-off-by: WenyXu <[email protected]>
e6b2f0b
to
a3b84a3
Compare
MichaelScofield
approved these changes
Sep 16, 2025
fengjiachun
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
fengjiachun
approved these changes
Sep 16, 2025
Signed-off-by: WenyXu <[email protected]>
auto-merge was automatically disabled
September 16, 2025 14:02
Pull Request is not mergeable
killme2008
pushed a commit
to killme2008/greptimedb
that referenced
this pull request
Sep 17, 2025
* refactor: move etcd tls code to `common-meta` Signed-off-by: WenyXu <[email protected]> * refactor: move postgre pool logic to `utils::postgre` Signed-off-by: WenyXu <[email protected]> * feat: setup mysql ssl options Signed-off-by: WenyXu <[email protected]> * feat: add test for mysql backend with tls Signed-off-by: WenyXu <[email protected]> * refactor: simplify certs generation Signed-off-by: WenyXu <[email protected]> * chore: apply suggestions Signed-off-by: WenyXu <[email protected]> --------- Signed-off-by: WenyXu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #6840
What's changed and what's your intention?
This PR introduces TLS support for MySQL backend and refactors the metadata backend utilities.
Changes
bootstrap.rs
to dedicated utility modules:utils::mysql
- MySQL connection pool and SSL configurationutils::postgres
- PostgreSQL connection pool logicutils::etcd
- etcd TLS configuration utilitiesPR Checklist
Please convert it to a draft if some of the following conditions are not met.