Skip to content

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 10, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR refactors the selector by exposing the previously hardcoded workload filtering behavior to external callers, allowing upper layers to specify custom filtering logic.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Sep 10, 2025
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu enabled auto-merge September 11, 2025 03:09
@WenyXu WenyXu added this pull request to the merge queue Sep 11, 2025
Merged via the queue into GreptimeTeam:main with commit 6a15e62 Sep 11, 2025
42 checks passed
@WenyXu WenyXu deleted the feat/selector-options branch September 11, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants