Skip to content

Conversation

MariamKhalatova
Copy link
Contributor

@MariamKhalatova MariamKhalatova commented Feb 2, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Dear GSF team,
    In scope of this PR integration test is provided, aiming to verify the integration of SCI-E model and IF framework.
    One test case included, covering the main flow - correct output creation in the console.
    Note: in the attached document energy-gpu is mentioned as an input parameter, however it is unused in the model itself.

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant- thanks so much for this!

@jmcook1186 jmcook1186 merged commit 9aa1821 into Green-Software-Foundation:dev Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants