Record IF version in output data #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.ts
Outdated
| @@ -12,6 +12,8 @@ import {STRINGS} from './config'; | |||
|
|
|||
| import {Impl} from './types/impl'; | |||
|
|
|||
| const pkg_json = require('../package.json'); | |||
There was a problem hiding this comment.
please use our formatting, like const package = require('../package.json');
src/index.ts
Outdated
| @@ -12,6 +12,8 @@ import {STRINGS} from './config'; | |||
|
|
|||
| import {Impl} from './types/impl'; | |||
|
|
|||
| const pkg_json = require('../package.json'); | |||
There was a problem hiding this comment.
please use our formatting, like const package = require('../package.json');
narekhovhannisyan
approved these changes
Jan 31, 2024
Signed-off-by: Joseph Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
IF will now automaticaly log its own version in the output data. This helps with audit verifiability since the execution environment can be reproduced more precisely from the output yaml alone. Also for debugging when we are only presented with an output yaml.