Add fill tool support on strokes #2664
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test cases: |
seam0s-dev
force-pushed
the
2615-fill-tool-on-strokes
branch
from
9741537 to
1a64e29
Compare
|
See the video for the issues this encounters: capture_10_.mp4Here's the file with this shape (remove the |
|
@Keavon The issue does not seem to affect shapes constructed using pen tool: ellipse_vs_path_shapes_fill_overlay.mp4 |
|
You likely need to take into account the local transform, the nested transform spaces to reach from local space to document space, and the stroke transform (which is affected by scaling or skewing a grouped layer, for example). |
|
!build |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fill on strokes while using the fill tool as requested in #2615.