[otlpmetric] update the collector version and use the metricstarttime processor #58
+58
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Config changes LGTM but there are a couple things we should do instead:
- Update this file instead: https://github.com/GoogleCloudPlatform/otlp-k8s-ingest/blob/main/config/collector.yaml and then run
make generateto create the config map automatically - Use the make command to update collector version in all the places instead of manually:
Line 46 in bc2c4a6
psx95
requested changes
Jun 2, 2025
There was a problem hiding this comment.
The Version file file has proper instructions/commands for version updates. The commands also mentioned here.
You might wanna also update the manifest version and tag new release for this change.
|
Updated |
psx95
reviewed
Jun 4, 2025
dashpole
force-pushed
the
add_metricstarttime
branch
from
da96b0e to
8939281
Compare
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Update the collector version to v0.127.0
Add the metricstarttime processor, and disable the prometheus adjuster to allow the metricstarttime processor to work.
Tested by adding a prometheus receiver to the metrics endpoint to scrape the GMP example app: https://cloud.google.com/stackdriver/docs/managed-prometheus/setup-managed#deploy-app