Skip to content

go.mod: use go 1.23 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 12, 2025
Merged

go.mod: use go 1.23 #1048

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
20b6429
go.mod: use go 1.23
braydonk Jun 3, 2025
e53fbbb
run make gotidy
braydonk Jun 3, 2025
cfc5ab8
use local toolchain in CI
braydonk Jun 3, 2025
729f791
empty commit to kick github
braydonk Jun 11, 2025
6072783
update golangci-lint
braydonk Jun 11, 2025
89cf36d
will this make the toolchain work
braydonk Jun 11, 2025
7cf461a
fixing vulns and setting env var better
braydonk Jun 11, 2025
fcae8a6
meant to set a different env var
braydonk Jun 11, 2025
5fce300
okay now I understand how this works
braydonk Jun 11, 2025
b2b2ec3
Remove toolchain directive and set local toolchain in
braydonk Jun 12, 2025
9afc788
Update go.mod
dashpole Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion detectors/gcp/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp

go 1.23.8
go 1.23.0

toolchain go1.24.2
Copy link
Contributor

@psx95 psx95 Jun 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this mean that at least go1.24.2 is required to build and compile this project? I'm ok with this, but is this intentional ?

Edit: Saw the failing lint - was this added to address the failed lint check ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toolchain is something that Go adds automatically now when you run go mod tidy. go1.24.2 was the local toolchain I was using. I've tried setting an env var in CI to ignore it.


require (
cloud.google.com/go/compute/metadata v0.7.0
Expand Down
4 changes: 3 additions & 1 deletion e2e-test-server/cloud_functions/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/e2e-test-server/cloudfunctions

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/pubsub v1.49.0
Expand Down
4 changes: 3 additions & 1 deletion e2e-test-server/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/e2e-test-server

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/pubsub v1.49.0
Expand Down
4 changes: 3 additions & 1 deletion example/metric/collector/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/metric/collector

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
go.opentelemetry.io/otel v1.36.0
Expand Down
4 changes: 3 additions & 1 deletion example/metric/exponential_histogram/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/metric/exponential_histogram

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.52.0
Expand Down
4 changes: 3 additions & 1 deletion example/metric/otlpgrpc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/metric/otlpgrpc

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
go.opentelemetry.io/contrib/detectors/gcp v1.35.0
Expand Down
4 changes: 3 additions & 1 deletion example/metric/sdk/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/metric/sdk

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.52.0
Expand Down
4 changes: 3 additions & 1 deletion example/trace/http/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/trace/http

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.28.0
Expand Down
4 changes: 3 additions & 1 deletion example/trace/otlpgrpc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/trace/otlpgrpc

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
go.opentelemetry.io/otel v1.36.0
Expand Down
4 changes: 3 additions & 1 deletion example/trace/otlphttp/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/example/trace/otlphttp

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
go.opentelemetry.io/otel v1.36.0
Expand Down
4 changes: 3 additions & 1 deletion exporter/collector/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/logging v1.13.0
Expand Down
4 changes: 3 additions & 1 deletion exporter/collector/googlemanagedprometheus/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/prometheus/common v0.62.0
Expand Down
4 changes: 3 additions & 1 deletion exporter/collector/integrationtest/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/integrationtest

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/logging v1.13.0
Expand Down
4 changes: 3 additions & 1 deletion exporter/metric/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/monitoring v1.24.2
Expand Down
4 changes: 3 additions & 1 deletion exporter/trace/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/trace v1.11.6
Expand Down
4 changes: 3 additions & 1 deletion extension/googleclientauthextension/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/extension/googleclientauthextension

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/stretchr/testify v1.10.0
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go

go 1.23.8
go 1.23

retract (
v1.8.0
Expand Down
4 changes: 3 additions & 1 deletion internal/cloudmock/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/cloudmock

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
cloud.google.com/go/logging v1.13.0
Expand Down
4 changes: 3 additions & 1 deletion internal/resourcemapping/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
go.opentelemetry.io/otel v1.36.0
Expand Down
4 changes: 3 additions & 1 deletion propagator/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/propagator

go 1.23.8
go 1.23.0

toolchain go1.24.2

require (
github.com/google/go-cmp v0.7.0
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/GoogleCloudPlatform/opentelemetry-operations-go/tools

go 1.23.8
go 1.23

require (
github.com/client9/misspell v0.3.4
Expand Down
Loading