-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add integration tests to verify table and index limits for bulk spanner migration from PostgreSQL #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add integration tests to verify table and index limits for bulk spanner migration from PostgreSQL #3103
Conversation
Note, this also updates the length of the BYTES row that we migrate because the previous value did not actually exceed the limit (it ended up being 7MiB, less than the 10MiB max). This now writes a value that's actually larger than the limit and verifies that the row is NOT saved.
Currently ignored because it causes OOMs on low-provisioned VMs/DBs
…igrating from Postgres
…when migrating from Postgres
Summary of ChangesHello @nmemond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness of the bulk Spanner migration tool by adding comprehensive integration tests. These tests are designed to ensure that the migration process correctly handles various data size constraints and limits imposed by Spanner, including those for individual string cells, entire rows, primary keys, and secondary indexes. This proactive testing helps prevent data integrity issues and ensures reliable migrations, particularly for large or complex datasets from PostgreSQL and MySQL sources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
============================================
+ Coverage 50.26% 55.64% +5.38%
+ Complexity 5021 1613 -3408
============================================
Files 967 468 -499
Lines 59268 26361 -32907
Branches 6458 2771 -3687
============================================
- Hits 29789 14669 -15120
+ Misses 27376 10800 -16576
+ Partials 2103 892 -1211
🚀 New features to boost your workflow:
|
This PR is built on top of #3033, that PR should be reviewed and merged first.
This adds integration tests to verify table and index limits during bulk spanner data migration from a PostgreSQL DB.
This includes tests for the following limits: