-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Template and Blueprint support for Kafka to Iceberg #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Template and Blueprint support for Kafka to Iceberg #3097
Conversation
Summary of ChangesHello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Dataflow template designed to streamline the process of ingesting real-time data from Kafka into Apache Iceberg tables. The template provides a robust, configurable solution for streaming data, allowing users to define Kafka connection details, message formats, and Iceberg catalog and table properties. This addition enhances the data integration capabilities by enabling efficient and scalable data transfer from Kafka to Iceberg, complete with an integration test to ensure reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3097 +/- ##
============================================
+ Coverage 50.40% 50.48% +0.07%
- Complexity 5021 5040 +19
============================================
Files 970 973 +3
Lines 59609 59721 +112
Branches 6507 6511 +4
============================================
+ Hits 30047 30151 +104
- Misses 27439 27442 +3
- Partials 2123 2128 +5
🚀 New features to boost your workflow:
|
| - kafka_read_options | ||
| - iceberg_common_options | ||
| - iceberg_write_options | ||
| - iceberg_streaming_write_options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I'm missing it, but where are the iceberg options defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, I was accidentally checking Apache Beam instead of GCP templates.
|
|
||
| - type: WriteToIceberg | ||
| name: WriteToIceberg | ||
| config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include direct_write_byte_limit here? Maybe a default limit could be 64 MB or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, you just added this to beam 2 weeks ago, Beam release is in progress, i can wait and add this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks!
No description provided.