Skip to content

Conversation

@tarun-google
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Dataflow template designed to streamline the process of ingesting real-time data from Kafka into Apache Iceberg tables. The template provides a robust, configurable solution for streaming data, allowing users to define Kafka connection details, message formats, and Iceberg catalog and table properties. This addition enhances the data integration capabilities by enabling efficient and scalable data transfer from Kafka to Iceberg, complete with an integration test to ensure reliability.

Highlights

  • New Dataflow Template: Introduced a new Dataflow template named 'Kafka to Iceberg (YAML)' for streaming data ingestion.
  • Streaming Data Pipeline: The template enables a streaming pipeline that reads data from Kafka topics and writes it to Apache Iceberg tables.
  • Comprehensive Configuration: Provides extensive configuration parameters for both Kafka source (e.g., bootstrap servers, topic, schema, format) and Iceberg sink (e.g., table, catalog properties, partition fields).
  • Integration Testing: Includes a dedicated integration test to ensure the end-to-end functionality and reliability of the Kafka to Iceberg template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.48%. Comparing base (52ba06f) to head (17b7120).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3097      +/-   ##
============================================
+ Coverage     50.40%   50.48%   +0.07%     
- Complexity     5021     5040      +19     
============================================
  Files           970      973       +3     
  Lines         59609    59721     +112     
  Branches       6507     6511       +4     
============================================
+ Hits          30047    30151     +104     
- Misses        27439    27442       +3     
- Partials       2123     2128       +5     
Components Coverage Δ
spanner-templates 70.74% <ø> (+0.09%) ⬆️
spanner-import-export 68.86% <ø> (-0.13%) ⬇️
spanner-live-forward-migration 80.10% <ø> (+0.07%) ⬆️
spanner-live-reverse-replication 77.82% <ø> (+0.35%) ⬆️
spanner-bulk-migration 88.23% <ø> (-0.02%) ⬇️
see 30 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tarun-google tarun-google changed the title Kafka iceberg Add Template and Blueprint support for Kafka to Iceberg Dec 10, 2025
@tarun-google tarun-google added the addition New feature or request label Dec 10, 2025
Comment on lines +26 to +29
- kafka_read_options
- iceberg_common_options
- iceberg_write_options
- iceberg_streaming_write_options

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I'm missing it, but where are the iceberg options defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I was accidentally checking Apache Beam instead of GCP templates.


- type: WriteToIceberg
name: WriteToIceberg
config:
Copy link

@tomstepp tomstepp Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include direct_write_byte_limit here? Maybe a default limit could be 64 MB or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, you just added this to beam 2 weeks ago, Beam release is in progress, i can wait and add this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants