-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Switch to AvroCoder for Reverse replication template #3073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @manitgupta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates a migration within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
=========================================
Coverage 50.41% 50.41%
Complexity 5022 5022
=========================================
Files 970 970
Lines 59609 59606 -3
Branches 6507 6507
=========================================
- Hits 30050 30049 -1
+ Misses 27436 27432 -4
- Partials 2123 2125 +2
🚀 New features to boost your workflow:
|
d6ed3fc to
010c828
Compare
|
The first round of Spanner integration tests had passed, and there was a failure on re-basing. This failure is unrelated to the changes in the PR (CassandraAllDataTypesIT failed and it is a bulk migration template IT) |
Functional testing
Load testing
AvroCoderv/sSerializableCoderI wrote a benchmark to compare the size and time efficiency of SerializableCoder and AvroCoder at https://github.com/manitgupta/beam-coder-benchmark
AvroCoderis 6x-12x faster on serialization and deserialization respectively, and generates encoded objects that are 8x smaller than SerializableCoder.