Skip to content

Conversation

bovandersteene
Copy link
Contributor

No description provided.

@bovandersteene bovandersteene self-assigned this Sep 8, 2025
@bovandersteene bovandersteene changed the title Feat/100 create tags on annotations feat: create tags on annotations Sep 8, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a tagging feature for annotations that allows displaying text tags associated with annotations. The feature supports both always-visible tags and hover-triggered tags.

Key changes:

  • Added a comprehensive tagging system with configurable display options
  • Refactored annotation model to track annotation dimensions for tag positioning
  • Updated annotation rendering to return position data needed for tag placement

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/core/src/lib/adapter/annotation/DefaultTag.ts Defines tag configuration interface and default settings
libs/core/src/lib/compute/draw/tag/ Implements tag drawing functionality including positioning and rendering
libs/core/src/lib/compute/annotation.model.ts Refactored to store annotation dimensions and manage draw annotations via map
libs/core/src/lib/compute/model/svg.types.ts Added tag SVG container and initialization
libs/core/src/lib/compute/draw/events/hover.ts Added tag drawing/removal on hover events
libs/core/src/lib/adapter/annotation/AnnotationAdapter.ts Integrated tag configuration into annotation adapter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bovandersteene bovandersteene linked an issue Sep 8, 2025 that may be closed by this pull request
@bovandersteene bovandersteene merged commit f334f18 into main Sep 9, 2025
6 checks passed
@bovandersteene bovandersteene deleted the feat/100-create-tags-on-annotations branch September 9, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tags on annotations
1 participant