Fix skins not loading when using Floodgate linking #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim203
requested changes
Dec 14, 2025
Member
Tim203
left a comment
Tim203
left a comment
There was a problem hiding this comment.
I think we need to look into this a bit more, but thanks for finding the skin resolve bug and the fact that we now have to resolve the skin for Spigot as well.
spigot/src/main/java/org/geysermc/floodgate/addon/data/SpigotDataHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems Velocity and Bungee using
player.getJavaUniqueId()when trying to obtain the skin when a player is using a linked account. JavaDocs state "Note that this field is not used when the player is a LinkedPlayer"Instead moving to
player.getCorrectUniqueId()get's the actual java players UUID so correctly finds the skin.Also Spigot/Paper/Bukkit appears to be missing a skin loop up completely, I have tried my best to implement it but may have not done so perfectly.