Skip to content

GPII-2843: Fix the broken browser channel example #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cindyli wants to merge 8 commits into
base: master
Choose a base branch
from
Open

GPII-2843: Fix the broken browser channel example #586

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8497efa
GPII-2843: Use the GPII config that includes the local flow manager t…
cindyli Feb 2, 2018
8837aaa
GPII-2843: Use gpii.config.development.all.local.mock.windows to supp…
cindyli Feb 2, 2018
417b798
GPII-2843: Fixed the browser channel example.
cindyli Mar 1, 2018
2523e1f
Merge branch 'master' into GPII-2843
cindyli Mar 1, 2018
d1928d2
GPII-2843: Switch to use "wget" from "curl" at building cloud based d…
cindyli Mar 1, 2018
43c33fe
Merge branch 'master' into GPII-2843
cindyli Mar 1, 2018
9330d2d
GPII-2843: Replaced "wget" work around with the change in the latest …
cindyli Mar 1, 2018
5c1d7f8
Merge branch 'master' into GPII-2843
cindyli Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentation/BrowserChannel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ The workflow between the client and server can be summarised as follows:
The client has been checked in to [../examples/browserChannelClient](../examples/browserChannelClient). To try it out, first
start the GPII in the CloudBased browserChannel test configuration from the root of universal with

node gpii.js gpii/configs gpii.config.cloudBased.production
node gpii.js gpii/configs gpii.config.development.all.local
Copy link
Member

@amb26 amb26 Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it will be more helpful to direct the user to one of our mock configurations like https://github.com/GPII/universal/blob/master/gpii/configs/mocks/gpii.config.development.all.local.mock.windows.json5 which will allow them to see the results of a wider range of preference sets


Then start the client from [../examples/browserChannelClient](../examples/browserChannelClient) with

Expand Down