Skip to content

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 13, 2024

TS-649

Release notes

In this release, we:

  • The selectNetwork connector method now accepts either url or chainId or both.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Sep 13, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 13, 2024
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:07am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 13, 2024 8:07am

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #3160 will improve performances by ×2.6

Comparing ps/chore/allow-select-network-to-accept-optional-params (4699be9) with master (a9f31ca)

Summary

⚡ 1 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark master ps/chore/allow-select-network-to-accept-optional-params Change
Instantiate a new Unlocked wallet 106.6 ms 40.6 ms ×2.6

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.08%(-0.12%) 71.64%(+0%) 75.73%(-0.08%) 77.19%(-0.12%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/vite.config.ts 0%
(+0%)
100%
(+100%)
0%
(+0%)
0%
(+0%)
🔴 ✨ packages/abi-typegen/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/account/tsup.config.ts 0%
(+0%)
100%
(+100%)
0%
(+0%)
0%
(+0%)
🔴 ✨ packages/contract/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/crypto/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/errors/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/fuels/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/transactions/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)
🔴 ✨ packages/utils/tsup.config.ts 0%
(+0%)
100%
(+100%)
100%
(+100%)
0%
(+0%)

@petertonysmith94 petertonysmith94 merged commit c21096c into master Sep 13, 2024
25 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/allow-select-network-to-accept-optional-params branch September 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow FuelConnector selectNetwork method to accept optional providerUrl and chainId
4 participants