Skip to content

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 4, 2024

Release notes

In this release, we:

  • Fixed revert error message assembling

Summary

This PR ensures that the correct Sway program logs are used whenever a transaction is reverted by the following validations: require, assert_eq, and assert_ne.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 4:28pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 4:28pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 4, 2024 4:28pm

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.38%(-0.02%) 72.09%(-0.03%) 77.76%(-0.01%) 79.45%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/account/src/providers/utils/extract-tx-error.ts 33.33%
(-1.67%)
11.11%
(+0%)
57.14%
(+0%)
34.78%
(-1.58%)
🔴 packages/account/src/test-utils/launchNode.ts 97.05%
(-0.03%)
87.71%
(+0%)
100%
(+0%)
97.19%
(-0.03%)

@Torres-ssf Torres-ssf merged commit 1b4db70 into master Sep 4, 2024
36 of 40 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/assemble-revert-messages branch September 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect log information why transaction was reverted
4 participants