Skip to content

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 4, 2024

Release notes

In this release, we:

  • Reduced number of requests for submitting a transaction
  • Fixed squeezed-out transactions not being notified to users

Summary

This PR replaces usage of submit mutation with submitAndAwaitStatus, thereby replacing the submit+statusChange calls with a single call. Instead of two, submitting a transaction and reading its results now requires only one request.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the feat Issue is a feature label Sep 4, 2024
@nedsalk nedsalk self-assigned this Sep 4, 2024
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:05am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 10:05am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 5, 2024 10:05am

@nedsalk nedsalk changed the title Ns/feat/submit and await feat: use submitAndAwaitStatus to submit transactions Sep 4, 2024
@nedsalk nedsalk added the bug Issue is a bug label Sep 4, 2024
@nedsalk nedsalk requested a review from danielbate September 5, 2024 08:54
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(-0.01%) 72.09%(-0.03%) 77.73%(-0.03%) 79.43%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/generated/operations.ts 95.71%
(-0.66%)
100%
(+0%)
86.66%
(-1.97%)
96.07%
(-0.61%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 77.27%
(+0.53%)
65.45%
(+2.71%)
93.75%
(+0%)
77.27%
(+0.53%)
🔴 packages/account/src/providers/utils/handle-gql-error-message.ts 83.33%
(-16.67%)
75%
(-25%)
100%
(+0%)
85.71%
(-14.29%)

Copy link
Contributor

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice

@nedsalk nedsalk merged commit 309b8d5 into master Sep 5, 2024
23 checks passed
@nedsalk nedsalk deleted the ns/feat/submit-and-await branch September 5, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions squeezed out in-between submit and statusChange calls hang indefinitely
5 participants