Skip to content

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 22, 2024

Fixes TS-443

Summary

This PR corrects the JSON ABI property name by renaming messagesTypes.message_id to messagesTypes.messageId, which is the correct name within a generated JSO ABI. The exhaustive-example contract has also been updated to include a method that generates entries for the messagesTypes array within its JSON ABI. A new test case has also been added to validate that the property is generated correctly.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added bug Issue is a bug feat Issue is a feature labels Aug 22, 2024
@Torres-ssf Torres-ssf self-assigned this Aug 22, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.16%(+0%) 71.81%(+0%) 75.77%(+0%) 77.27%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit 48db506 into master Sep 19, 2024
24 of 25 checks passed
@arboleya arboleya deleted the st/fix/rename-abi-message-id-property branch September 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support messagesTypes for the ABI
7 participants