Skip to content

feat: add missing connectors to create fuels template #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2024
Merged

feat: add missing connectors to create fuels template #3013

merged 5 commits into from
Aug 29, 2024

Conversation

Dhaiwat10
Copy link
Contributor

@Dhaiwat10 Dhaiwat10 commented Aug 22, 2024 •
edited
Loading

Release notes

In this release, we:

  • Added Solana connector to create-fuels template app

Summary

This PR ensures that the create fuels template app supports all the available connectors.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Aug 22, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 22, 2024
danielbate
danielbate previously approved these changes Aug 23, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Aug 23, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Aug 23, 2024
View reviewed changes
petertonysmith94
petertonysmith94 reviewed Aug 26, 2024
View reviewed changes
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:35am
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 29, 2024 9:35am

petertonysmith94
petertonysmith94 reviewed Aug 28, 2024
View reviewed changes
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) August 29, 2024 09:31
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.82%(-0.04%) 77.7%(+0%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)		 78.26%
(-1.45%)		 84%
(+0%)		 88.73%
(+0%)

@Dhaiwat10 Dhaiwat10 merged commit e87b51b into master Aug 29, 2024
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-all-connectors branch August 29, 2024 09:53
@fuel-service-user fuel-service-user mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm

@nedsalk nedsalk Awaiting requested review from nedsalk

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf

4 more reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure support for all connectors in create fuels template
6 participants
@Dhaiwat10 @arboleya @danielbate @maschad @petertonysmith94 @Torres-ssf