Skip to content

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 6, 2024

Release notes

In this release, we:

  • Fixed forc and fuel-core version reporting on typegen-generated files

Summary

  • Currently, we add the "built in" versions of the SDK to the typegen'd files, which doesn't reflect that of the user.
  • This change does two things:
    • fuels build - we add the versions of the forc and fuel-core that has been configured (via config).
    • fuels typegen - these versions will no longer be present, as we don't know which versions these were built with.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Aug 6, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 6, 2024
@petertonysmith94 petertonysmith94 changed the title Ps/chore/versions in typegen fix: typegen reporting the correct versions Aug 6, 2024
@github-actions github-actions bot added the bug Issue is a bug label Aug 6, 2024
Torres-ssf
Torres-ssf previously approved these changes Aug 8, 2024
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts to fix.

@Dhaiwat10
Copy link
Contributor

There is a typo in the release notes:

Versions for FORC and FUEL_CORE in typegen files, better reflect that actual versions.

should be

Versions for FORC and FUEL_CORE in typegen files better reflect their actual versions.

Copy link
Contributor

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another take on the release notes:

  • Fixed forc and fuel-core version reporting on typegen-generated files

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.76%(+0.02%) 72.08%(+0.05%) 77.73%(+0.02%) 79.9%(+0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
✨ packages/versions/src/lib/getBinaryVersions.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)

@petertonysmith94 petertonysmith94 merged commit 29c556d into master Aug 12, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/versions-in-typegen branch August 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typegend templates are misreporting the versions they are using
5 participants