Fix TermLogger and ProgressLogging compatibility #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the TermLogger progress bar printed nothing because the minimum log level was set to
Inforather thanProgressLevel, and theupdate!method would increment by the value ofi(rather than setting the value toi, as suggested by the docs and code base), causing the progress bar to overflowTo test the TermLogger functionality, I also made sure a custom io could be passed to TermLogger (and therefore ProgressBar)
ProgressLogging integration should now work as described in the docs