Fix animation speed modification in other locales #642
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done |
Collaborator
|
Awesome! Can you change the second line to use property syntax for the setter? Then I can merge this. Thank you so much! |
Contributor
Author
|
Can we get this merged? |
Collaborator
|
Idk why but the GitHub all has stopped sending me push notifications, I'm sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some locales where the decimal separator isn't a dot, the animation speed editor doesn't work with decimal value.
The
UIKeyboardTypeDecimalPadkeyboard has a comma key in French, but it is then parsed expecting a dot for the decimal.I changed it to use
NSNumberFormatter, which is locale-aware, and correctly expects a comma as a decimal separator in such languages.