Skip to content

Conversation

@benkrikler
Copy link
Member

This PR adds the functionality of variable broadcasting before passing into numexpr.
This means we can now mix variables with different jaggedness more conveniently within expressions, with less need for external stages.

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@072cc2f). Click here to learn what that means.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #122   +/-   ##
=========================================
  Coverage          ?   65.97%           
=========================================
  Files             ?       20           
  Lines             ?     1487           
  Branches          ?        0           
=========================================
  Hits              ?      981           
  Misses            ?      506           
  Partials          ?        0           
Impacted Files Coverage Δ
fast_carpenter/expressions.py 94.73% <95.34%> (ø)
fast_carpenter/version.py 100.00% <100.00%> (ø)
fast_carpenter/backends/alphatwirl.py 21.42% <0.00%> (ø)
fast_carpenter/define/reductions.py 75.64% <0.00%> (ø)
fast_carpenter/summary/import_aghast.py 57.14% <0.00%> (ø)
fast_carpenter/__main__.py 0.00% <0.00%> (ø)
fast_carpenter/help.py 0.00% <0.00%> (ø)
fast_carpenter/summary/binning_config.py 80.00% <0.00%> (ø)
fast_carpenter/define/systematics.py 89.13% <0.00%> (ø)
... and 12 more

@benkrikler benkrikler merged commit 7f887b9 into master Jun 16, 2020
@benkrikler benkrikler deleted the BK_broadcast_expressions branch June 16, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants