Use NSTextStorageDelegate instead of method swizzling
#520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
maksg
reviewed
Oct 22, 2024
maksg
reviewed
Oct 22, 2024
maksg
reviewed
Oct 22, 2024
tomekzaw
commented
Oct 31, 2024
tomekzaw
commented
Oct 31, 2024
j-piasecki
reviewed
Nov 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…TextFieldObserver`
tomekzaw
force-pushed
the
@tomekzaw/NSTextStorageDelegate
branch
from
9a4f995 to
40abeba
Compare
Collaborator
Author
|
Spellcheck works Screen.Recording.2025-05-12.at.14.48.49.mov |
Collaborator
Author
|
Autocorrection works Screen.Recording.2025-05-12.at.14.49.56.mov |
Collaborator
Author
|
Autocomplete works Screen.Recording.2025-05-12.at.16.06.58.mov |
Collaborator
Author
|
Typing fast works Screen.Recording.2025-05-12.at.16.08.00.mov |
Collaborator
Author
|
Blockquote works Screen.Recording.2025-05-12.at.16.08.27.mov |
Collaborator
Author
|
Focus/blur works Screen.Recording.2025-05-12.at.16.10.38.mov |
Collaborator
Author
|
Clear/reset works Screen.Recording.2025-05-12.at.16.10.55.mov |
Collaborator
Author
|
Toggling styles works Screen.Recording.2025-05-12.at.16.11.43.mov |
Collaborator
Author
|
Multi-stage input works Screen.Recording.2025-05-12.at.16.36.00.mov |
This was referenced May 13, 2025
j-piasecki
approved these changes
May 13, 2025
Collaborator
j-piasecki
left a comment
j-piasecki
left a comment
There was a problem hiding this comment.
I didn't test whether it actually works, but the code looks solid 🪨
|
Recordings from testing in App Searchsearch.movComposercomposer.mov |
Contributor
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR is supposed to fix these issues:
multilineprop #309Related Issues
GH_LINK
Manual Tests
Linked PRs