Skip to content

Conversation

@war-in
Copy link
Contributor

@war-in war-in commented Aug 29, 2025

Explanation of Change

Updates React Native version to the newest stable - 0.81.4. Also, updates Expo and its dependencies

Fixed Issues

$ #65991
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13670

Tests

Requires full regression tests on the entire app

Offline tests

QA Steps

Requires full regression tests on the entire app

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@github-actions
Copy link
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@war-in war-in changed the title Align with React Native upgrade (v0.81.1) Upgrade React Native to v0.81.1 Aug 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@nlemma
Copy link

nlemma commented Oct 25, 2025

Group-"You don't have access to this chat" when sending message in group with custom avatar

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.2.37-1 PR:69535 Ad-Hoc
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176684/test-cases/41236576
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.5
App Component: undefined

Action Performed:

  1. Sign in to ND with build v9.2.37-1 PR:69535 Ad-Hoc
  2. Tap FAB - Start chat
  3. Search for another user and tap "Add to group", add 2 or more users to the group
  4. Tap Next, then upload a new avatar to the group chat
  5. Start a group
  6. Send a message in the group chat
  7. Navigate away and open the group chat again

Expected Result:

User is able to successfully send a message in a group chat with a custom avatar

Actual Result:

User is not able to send a message in a group chat with a custom avatar. The error "You don't have access to this chat" appears, the group chat shows loading animation at the top

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6983395_1761323157308.Error_in_group_chat.MP4

View all open jobs on GitHub

@nlemma
Copy link

nlemma commented Oct 25, 2025

Accounting-Not able to connect to QBO, blank page shown instead of Sign in page

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.2.37-1 PR:69535 Ad-Hoc
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176890/test-cases/41237385
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.5
App Component: undefined

Action Performed:

  1. Sign in to ND with build v9.2.37-1 PR:69535 Ad-Hoc
  2. Create a workspace
  3. Navigate to Workspace settings - More features and enable "Accounting"
  4. Open Accounting tab, tap "Connect button" next to the QBO

Expected Result:

User is navigated to Sign in page, where the credentials can be entered

Actual Result:

Blank page opens instead of Sign in page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6983541_1761332769635.QBO_connect.MP4

View all open jobs on GitHub

@war-in
Copy link
Contributor Author

war-in commented Oct 27, 2025

Group-"You don't have access to this chat" when sending message in group with custom avatar - issue no longer reproducible after merging main

Accounting-Not able to connect to QBO, blank page shown instead of Sign in page - I can reproduce this issue on the main branch too, so not related

cc @nlemma

mountiny
mountiny previously approved these changes Oct 27, 2025
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Applause is done and all the issues found been resolved by @war-in is only repro on this branch.

I believe this is ready for a final review and merge @roryabraham

@mitarachim
Copy link

Share - Unexpected error after sharing an image via Gallery

Version Number: v9.2.37-1 Ad-hoc
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176721/test-cases/41236967
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to Gallery
  2. Open the attached image.
  3. Tap Share > Expensify Adhoc > Select any chat > Share

Expected Result:

When sharing an image through the Gallery, the action should complete successfully without triggering any errors.

Actual Result:

After sharing an image via the Gallery, an unexpected error appears

Error Message

'Unexpected error posting the comment. Please try again later'

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6986178_1761598275881.Android_adhoc_issue.mp4

@mitarachim
Copy link

@mountiny QA team found one more issue which seem to specific to this build v9.2.37-1 Ad-hoc. Can you pls double check its not related before deploying?

@war-in
Copy link
Contributor Author

war-in commented Oct 28, 2025

roryabraham
roryabraham previously approved these changes Oct 28, 2025
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple non-blocking suggestions, otherwise LGTM 👍🏼

@roryabraham
Copy link
Contributor

conflicts tho

# Conflicts:
#	ios/Podfile.lock
#	package-lock.json
#	patches/react-native/details.md
#	src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
@war-in war-in dismissed stale reviews from roryabraham and mountiny via 60e4461 October 29, 2025 11:00
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Since Rory already approved, I will move this ahead now that all actions are passing and we dont have any conflicts

Great effort @war-in @dukenv0307 ! Lets be on a look out for any build issues or deploy blockers in staging now

@mountiny mountiny merged commit 3341c09 into Expensify:main Oct 29, 2025
33 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.41-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya
Copy link

Hi @war-in What specific steps do we need to check?

QA Steps
Requires full regression tests on the entire app

@war-in
Copy link
Contributor Author

war-in commented Oct 30, 2025

@izarutskaya the regression testing has been performed on this PR so I guess nothing? 🤔
cc @mountiny for confirmation

@mountiny
Copy link
Contributor

This is basically no QA as the full regression suite has to be done to cover all cases

@mountiny mountiny changed the title Upgrade React Native to v0.81.4 [NoQA] Upgrade React Native to v0.81.4 Oct 30, 2025
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants