-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[NoQA] Upgrade React Native to v0.81.4 #69535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Upgrade React Native to v0.81.4 #69535
Conversation
# Conflicts: # package-lock.json # package.json
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json
Group-"You don't have access to this chat" when sending message in group with custom avatarIf you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel! Version Number: v9.2.37-1 PR:69535 Ad-Hoc Action Performed:
Expected Result:User is able to successfully send a message in a group chat with a custom avatar Actual Result:User is not able to send a message in a group chat with a custom avatar. The error "You don't have access to this chat" appears, the group chat shows loading animation at the top Workaround:Unknown Platforms:
Screenshots/VideosBug6983395_1761323157308.Error_in_group_chat.MP4 |
Accounting-Not able to connect to QBO, blank page shown instead of Sign in pageIf you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel! Version Number: v9.2.37-1 PR:69535 Ad-Hoc Action Performed:
Expected Result:User is navigated to Sign in page, where the credentials can be entered Actual Result:Blank page opens instead of Sign in page Workaround:Unknown Platforms:
Screenshots/VideosBug6983541_1761332769635.QBO_connect.MP4 |
|
Group-"You don't have access to this chat" when sending message in group with custom avatar - issue no longer reproducible after merging main Accounting-Not able to connect to QBO, blank page shown instead of Sign in page - I can reproduce this issue on the main branch too, so not related cc @nlemma |
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Applause is done and all the issues found been resolved by @war-in is only repro on this branch.
I believe this is ready for a final review and merge @roryabraham
Share - Unexpected error after sharing an image via GalleryVersion Number: v9.2.37-1 Ad-hoc Action Performed:
Expected Result:When sharing an image through the Gallery, the action should complete successfully without triggering any errors. Actual Result:After sharing an image via the Gallery, an unexpected error appears Error Message'Unexpected error posting the comment. Please try again later' Workaround:Unknown Platforms:
Screenshots/VideosBug6986178_1761598275881.Android_adhoc_issue.mp4 |
|
Share - Unexpected error after sharing an image via Gallery - fixed! Probably same RCA as with expo patch |
roryabraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple non-blocking suggestions, otherwise LGTM 👍🏼
src/components/ScreenWrapper/ScreenWrapperOfflineIndicators.tsx
Outdated
Show resolved
Hide resolved
|
conflicts tho |
# Conflicts: # ios/Podfile.lock # package-lock.json # patches/react-native/details.md # src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Since Rory already approved, I will move this ahead now that all actions are passing and we dont have any conflicts
Great effort @war-in @dukenv0307 ! Lets be on a look out for any build issues or deploy blockers in staging now
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.41-0 🚀
|
|
Hi @war-in What specific steps do we need to check?
|
|
@izarutskaya the regression testing has been performed on this PR so I guess nothing? 🤔 |
|
This is basically no QA as the full regression suite has to be done to cover all cases |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀
|
Explanation of Change
Updates React Native version to the newest stable - 0.81.4. Also, updates Expo and its dependencies
Fixed Issues
$ #65991
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13670
Tests
Requires full regression tests on the entire app
Offline tests
QA Steps
Requires full regression tests on the entire app
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop