Skip to content

Conversation

@kewde
Copy link

@kewde kewde commented Mar 28, 2025

Summary

Test plan

@alexandrius
Copy link

getting this

Screenshot 2025-03-29 at 03 56 50

@kewde kewde force-pushed the kewde/remove-eval branch from ec0bbcb to 1390eab Compare March 29, 2025 04:56
@kewde
Copy link
Author

kewde commented Mar 29, 2025

I've based it off 3.16.7-rc.8 to keep it simple and avoid having to deal with any symbol stuff that was introduced, should be easy to add though.

I've verified that it works on mobile, see branch kewde/reanimated-poc - copy over the cpp changes & rig valueUnpacker a bit, it's TS here but in mobile just edit the JS to do a similar thing.

Copy link

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

  • Needs to base of rc.9 changes. With valueUnpacker brought back.
  • evalWithSourceMap can now be removed

@alexandrius alexandrius mentioned this pull request Mar 31, 2025
@alexandrius alexandrius changed the title fix: poc remove eval fix: remove eval Mar 31, 2025
@mvayngrib mvayngrib merged commit 3b06634 into exodus-3.16.7 Apr 1, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants