Skip to content

Conversation

@kewde
Copy link

@kewde kewde commented Apr 7, 2025

Summary

  • ditch the cppruntime - it's never used by our react native impl & original hermes version doesn't ship it either
  • add prefabs to the AAR because react-native-reanimated and friends that rely on the hermes-engine dependency being available in CMake through prefabs.

TODO:

  • .aar file should contain prefabs folder
  • with name "hermes-engine" inside the prefab.json
  • the libs/ shipped should be of the same size as the ones shipped on Maven by official build edit: we need to strip the prefab libraries they're fat with symbols

Test Plan

  • npm package works with reanimated 3 in a production build

Copy link
Collaborator

@alexandrius alexandrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK thanks

@kewde kewde merged commit 8b37aa3 into exodus-fork Apr 9, 2025
6 checks passed
@kewde kewde deleted the kewde/add-prefabs-for-reanimated branch April 9, 2025 13:59
kewde added a commit that referenced this pull request Apr 21, 2025
* fix: add prefabs to hermes-engine & remove

* fix: properly move aar file

* fix: strip debug symbols on release build

* fix: also enable for debug builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants