Render 'content_footer' block with raw filter in layout #6913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering `content_footer|raw` enables to use HTML in the block.
Collaborator
|
Evert, thanks for this contribution. I was going to merge it but then I double checked it and thought that the original code (before your fix) was really strange. It's convoluted, and not only it breaks HTML contents, but also basic Twig features such as So, I'm proposing some changes in #6926 that will fix your issue and will improve all the other things. So, I'm closing this PR in favor of the other one. Thanks! |
Contributor
Author
|
That's indeed a much more elegant solution, I didn't want to bluntly change any 'code style'. Thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering
content_footer|rawenables to use HTML in the block. Currently there is no other way of using HTML when defining thecontent_footerblock in your own template. And this shouldn't cause any BC-problems AFAIK.