[chore] fix expected service name for prometheus e2e test #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics exposed by the collector's self monitoring prometheus endpoint at port
8888
contain aservice_name="dynatrace-otel-collector"
label, which is used for the resulting resource name.Previously, apparently the job name from the prometheus config has been used for the service name:
I'm not 100% sure yet why this has changed with the new upstream release, but my guess is that this is linked to the recent major version upgrade of the prometheus dependency: open-telemetry/opentelemetry-collector-contrib#36873
Update: It seems like since the prometheus version upgrade, the prometheus scrape manager will convert the
service_name
label provided by the collector self monitoring metrics toservice.name
, which is then set as a resource attribute by the prometheus receiver, overriding the previousservice.name
value determined by thejob
label