Skip to content

Conversation

@nyafunta9858
Copy link
Contributor

Issue

Overview (Required)

  • R8 causes fatal error in Firebase Firestore,

Links

Screenshot

Before After

maven { url "http://storage.googleapis.com/r8-releases/raw/master" }
}
dependencies {
classpath Dep.GradlePlugin.r8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be before the Gradle Plugin for Android in the following conversation.So I wrote here.
https://issuetracker.google.com/issues/114554345#comment17

@jmatsu-bot
Copy link
Collaborator

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 7919565 Bytes. (7.55 MB)
File Size Change -144517 Bytes. (-141.13 KB)
Download Size Change -143156 Bytes. (-139.8 KB)
New Method Reference Count 60457
Method Reference Count Change 456
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for investigating 🏅

@takahirom takahirom merged commit 305ebb9 into DroidKaigi:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix crash when open or clicking favorite

3 participants