Skip to content

Enable R8 for release build #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmatsu merged 18 commits into from
Jan 28, 2019
Merged

Enable R8 for release build #596

jmatsu merged 18 commits into from
Jan 28, 2019

Conversation

@jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Jan 23, 2019

Issue

Overview (Required)

  • Enabling proguard files... 🤖

Links

@jmatsu jmatsu added the wip label Jan 23, 2019
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 24, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

2 similar comments
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 24, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 24, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 24, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

@jmatsu jmatsu changed the title [wip] Enable proguard for release build Enable proguard for release build Jan 24, 2019
@jmatsu jmatsu added wip and removed wip labels Jan 24, 2019
@jmatsu
Copy link
Contributor Author

jmatsu commented Jan 24, 2019

Hi guys, could you please play this apk as well? 🙇

@tomoya0x00
Copy link
Contributor

tomoya0x00 commented Jan 24, 2019

On my Pixel 3 XL, this apk is working well! 🆒

@jmatsu jmatsu removed the wip label Jan 25, 2019
@jmatsu
Copy link
Contributor Author

jmatsu commented Jan 25, 2019

https://pbs.twimg.com/media/CI3WZNRUwAEGrXz.jpg

@jmatsu jmatsu changed the title Enable proguard for release build Enable R8 for release build Jan 25, 2019
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 26, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

1 similar comment
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 26, 2019

Your app is deployed! Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 26, 2019

Apk comparision results

Property Summary
New File Size 7656363 Bytes. (7.3 MB)
File Size Change -6464592 Bytes. (-6313.08 KB)
Download Size Change -6326999 Bytes. (-6178.71 KB)
New Method Reference Count 66411
Method Reference Count Change -90484
New Number of dex file(s) 2
Number of dex file(s) Change -2
Removed Permissions - android.permission.READ_EXTERNAL_STORAGE
- android.permission.WRITE_EXTERNAL_STORAGE

Generated by 🚫 Danger

jmatsu
jmatsu commented Jan 26, 2019
View reviewed changes
frontend/android/build.gradle

implementation Dep.Stetho.stetho

releaseImplementation Dep.LeakCanary.leakCanary
Copy link
Contributor Author

@jmatsu jmatsu Jan 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

takahirom
takahirom reviewed Jan 27, 2019
View reviewed changes
frontendcomponent/androidcomponent/build.gradle
fqdns << className
}
} else if (line.startsWith("app:argType=\"")) {
def className = line.substring("app:argType=\"".length(), line.lastIndexOf("\""))
Copy link
Member

@takahirom takahirom Jan 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝

takahirom
takahirom reviewed Jan 27, 2019
View reviewed changes
gradle/android.gradle
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
consumerProguardFiles 'proguard-rules.pro'
Copy link
Member

@takahirom takahirom Jan 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

takahirom
takahirom approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DroidKaigi DroidKaigi deleted a comment from jmatsu-bot Jan 27, 2019
@DroidKaigi DroidKaigi deleted a comment from jmatsu-bot Jan 27, 2019
@DroidKaigi DroidKaigi deleted a comment from jmatsu-bot Jan 27, 2019
@DroidKaigi DroidKaigi deleted a comment from jmatsu-bot Jan 27, 2019
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 27, 2019

Try it via https://deploygate.com/distributions/380374417aee3b410b8128fee2e6cf00ba3ee9ad

@takahirom takahirom mentioned this pull request Jan 27, 2019
Open
@jmatsu-bot
Copy link
Collaborator

jmatsu-bot commented Jan 28, 2019

Asserted successfully. 💯

Generated by 🚫 Danger

@jmatsu
Copy link
Contributor Author

jmatsu commented Jan 28, 2019

Let me merge as well

@jmatsu jmatsu merged commit 45d02b4 into master Jan 28, 2019
@jmatsu jmatsu deleted the enable_proguard branch January 28, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takahirom takahirom takahirom approved these changes

Assignees

No one assigned

Labels

awesome

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Proguard for release build

5 participants

@jmatsu @jmatsu-bot @tomoya0x00 @takahirom