Skip to content

Conversation

@ma2gedev
Copy link
Contributor

@ma2gedev ma2gedev commented Jan 9, 2019

Issue

Overview (Required)

Links

Screenshot

There is no screenshot but build speed faster than before, I could not measure accurately though.

The following is synchronization time on my MacBook Air. I only measured once.

Before After
synced successfully 10m 29s 199ms synced successfully 8m 30s 38ms

@jmatsu-bot
Copy link
Collaborator

@takahirom
Copy link
Member

Since CI's server is overseas, how about judging whether it is CI server or not like this?

def isCi = System.getenv("CI") == "true"

        google()
        if (!isCi) { maven { url "https://maven-central-asia.storage-download.googleapis.com/repos/central/data/" } }
        jcenter()

@jmatsu-bot
Copy link
Collaborator

@ma2gedev
Copy link
Contributor Author

Since CI's server is overseas, how about judging whether it is CI server or not like this?

Wow, I have not noticed about CI. That is a cool idea so I will check it later tonight in JST.

- add `isCi` as an extra property for DRYing up code
@jmatsu-bot
Copy link
Collaborator

@ma2gedev
Copy link
Contributor Author

I added isCi as extra property but please tell me if there is any other good way.

@jmatsu-bot
Copy link
Collaborator

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 13815104 Bytes. (13.18 MB)
File Size Change +280647 Bytes. (+274.07 KB)
Download Size Change +43760 Bytes. (+42.73 KB)
New Method Reference Count 150723
Method Reference Count Change -24
New Number of dex file(s) 4
Number of dex file(s) Change 0

Generated by 🚫 Danger

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is very useful for all projects!

@takahirom takahirom merged commit 81df3c6 into DroidKaigi:master Jan 10, 2019
@ma2gedev
Copy link
Contributor Author

Thank you so much!

@ma2gedev ma2gedev deleted the use-maven-central-mirror branch January 10, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faster build by using Maven Central mirror hosted on Google Cloud Storage

3 participants