Skip to content

fix(Table): 修复列排序bug;d-column增加默认插槽;抽离部分逻辑,降低圈复杂度 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 51 additions & 43 deletions packages/devui-vue/devui/table/src/column/use-column.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { watch, reactive, onBeforeMount, ToRefs, Slots, h } from 'vue';
import { Column, TableColumnPropsTypes } from './column.type'
import { Column, TableColumnPropsTypes } from './column.type';
import { formatWidth, formatMinWidth } from '../utils';

function defaultRenderHeader(this: Column) {
return h('span', { class: 'title' }, this.header);
}

export function createColumn<T extends Record<string, unknown> = any>(
props: ToRefs<TableColumnPropsTypes>,
templates: Slots
): Column<T> {
export function createColumn<T extends Record<string, unknown> = any>(props: ToRefs<TableColumnPropsTypes>, templates: Slots): Column<T> {
const {
field,
header,
Expand All @@ -20,43 +20,63 @@ export function createColumn<T extends Record<string, unknown> = any>(
filterMultiple,
order,
fixedLeft,
fixedRight
fixedRight,
} = props;
const column: Column = reactive({});

watch([field, header, order], ([field, header, order]) => {
column.field = field;
column.header = header;
column.order = order;
}, { immediate: true });
function defaultRenderCell<K extends Record<string, unknown>>(rowData: K, index: number) {
const value = rowData[this.field];
if (templates.default) {
return templates.default(rowData);
}
if (this.formatter) {
return this.formatter(rowData, value, index);
}

return value?.toString?.() ?? '';
}

watch(
[field, header, order],
([fieldVal, headerVal, orderVal]) => {
column.field = fieldVal;
column.header = headerVal;
column.order = orderVal;
},
{ immediate: true }
);

// 排序功能
watch([sortable, compareFn], ([sortable, compareFn]) => {
column.sortable = sortable;
column.compareFn = compareFn;
})
watch([sortable, compareFn], ([sortableVal, compareFnVal]) => {
column.sortable = sortableVal;
column.compareFn = compareFnVal;
});

// 过滤功能
watch([
filterable,
filterList,
filterMultiple,
], ([filterable, filterList, filterMultiple]) => {
column.filterable = filterable;
column.filterMultiple = filterMultiple;
column.filterList = filterList;
}, { immediate: true })
watch(
[filterable, filterList, filterMultiple],
([filterableVal, filterListVal, filterMultipleVal]) => {
column.filterable = filterableVal;
column.filterMultiple = filterMultipleVal;
column.filterList = filterListVal;
},
{ immediate: true }
);

// 固定左右功能
watch([fixedLeft, fixedRight], ([left, right]) => {
column.fixedLeft = left;
column.fixedRight = right;
}, { immediate: true });
watch(
[fixedLeft, fixedRight],
([left, right]) => {
column.fixedLeft = left;
column.fixedRight = right;
},
{ immediate: true }
);

// 宽度
watch([width, minWidth], ([width, minWidth]) => {
column.width = formatWidth(width);
column.minWidth = formatMinWidth(minWidth);
watch([width, minWidth], ([widthVal, minWidthVal]) => {
column.width = formatWidth(widthVal);
column.minWidth = formatMinWidth(minWidthVal);
column.realWidth = column.width || column.minWidth;
});

Expand All @@ -71,15 +91,3 @@ export function createColumn<T extends Record<string, unknown> = any>(

return column;
}

function defaultRenderHeader(this: Column) {
return h('span', { class: 'title' }, this.header);
}

function defaultRenderCell<T extends Record<string, unknown>>(this: Column, rowData: T, index: number) {
const value = rowData[this.field];
if (this.formatter) {
return this.formatter(rowData, value, index);
}
return value?.toString?.() ?? '';
}
36 changes: 36 additions & 0 deletions packages/devui-vue/devui/table/src/fix-header.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import { defineComponent } from 'vue';
import ColGroup from './colgroup/colgroup';
import TableHeader from './header/header';
import TableBody from './body/body';

export default defineComponent({
props: {
classes: {
type: Object,
default: () => ({}),
},
isEmpty: {
type: Boolean,
},
},
setup(props: { classes: Record<string, unknown>; isEmpty: boolean }) {
return () => {
return (
<div class='devui-table-view'>
<div style='overflow:hidden scroll;'>
<table class={props.classes} cellpadding='0' cellspacing='0'>
<ColGroup />
<TableHeader />
</table>
</div>
<div class='scroll-view'>
<table class={props.classes} cellpadding='0' cellspacing='0'>
<ColGroup />
{!props.isEmpty && <TableBody style='flex: 1' />}
</table>
</div>
</div>
);
};
},
});
27 changes: 27 additions & 0 deletions packages/devui-vue/devui/table/src/normal-header.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { defineComponent } from 'vue';
import ColGroup from './colgroup/colgroup';
import TableHeader from './header/header';
import TableBody from './body/body';

export default defineComponent({
props: {
classes: {
type: Object,
default: () => ({}),
},
isEmpty: {
type: Boolean,
},
},
setup(props: { classes: Record<string, unknown>; isEmpty: boolean }) {
return () => {
return (
<table class={props.classes} cellpadding='0' cellspacing='0'>
<ColGroup />
<TableHeader style='position:relative' />
{!props.isEmpty && <TableBody />}
</table>
);
};
},
});
Loading