lazy load protobuf so that it is not loaded when not needed #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lazy load protobuf so that it is not loaded when not needed.
Motivation
After the changes introduced in #16, protobuf is now by far the biggest contributor to the load time of the library. Lazy loading it only when needed reduces the loading time by ~5x. This has the downside however to potentially be loading protobuf during a request at runtime, which could introduce latency for the first request while the library is loading. The proper way to handle this would be to split
sketches-jsin multiple packages, so that it is known at install time whether protobuf will be used. This however means a much bigger change, but if it's a possibility then it should be favoured over this PR.