Skip to content

[OTel] Remove explicit tags for Collector image #15586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -126,18 +126,13 @@ To get better metadata for traces and for smooth integration with Datadog:

Run an Opentelemetry Collector container to receive traces either from [localhost](#receive-traces-from-localhost), or from [other containers](#receive-traces-from-other-containers).

<div class="alert alert-info">
The latest tag of the OpenTelemetry Collector Contrib distro <a href="https://github.com/open-telemetry/opentelemetry-collector-releases/issues/73">is not updated on every release</a>.
Pin the Collector to the latest version to pick up the latest changes.
</div>

### Receive traces from localhost

To run the OpenTelemetry Collector as a Docker image and receive traces from the same host:

1. Create a `collector.yaml` file. You may use the [example template above](#configuring-the-datadog-exporter) to get started.

2. Choose a published Docker image such as [`otel/opentelemetry-collector-contrib:<VERSION>`][10].
2. Choose a published Docker image such as [`otel/opentelemetry-collector-contrib`][10].

3. Determine which ports to open on your container so that OpenTelemetry traces are sent to the OpenTelemetry Collector. By default, traces are sent over gRPC on port 4317. If you don't use gRPC, use port 4138.

Expand All @@ -148,7 +143,7 @@ To run the OpenTelemetry Collector as a Docker image and receive traces from the
-p 4317:4317 \
--hostname $(hostname) \
-v $(pwd)/otel_collector_config.yaml:/etc/otelcol-contrib/config.yaml \
otel/opentelemetry-collector-contrib:<VERSION>
otel/opentelemetry-collector-contrib
```

5. Make sure you've configured your application with the appropriate resource attributes for [unified service tagging](#unified-service-tagging).
Expand All @@ -175,7 +170,7 @@ To run the OpenTelemetry Collector as a Docker image and receive traces from oth
--network <NETWORK_NAME> \
--hostname $(hostname) \
-v $(pwd)/otel_collector_config.yaml:/etc/otelcol-contrib/config.yaml \
otel/opentelemetry-collector-contrib:<VERSION>
otel/opentelemetry-collector-contrib
```

When running the application container, ensure that the environment variable `OTEL_EXPORTER_OTLP_ENDPOINT` is configured to use the appropriate hostname for the OpenTelemetry Collector. In the example below, this is `opentelemetry-collector`.
Expand Down Expand Up @@ -313,7 +308,7 @@ To use the OpenTelemetry Operator:
spec:
mode: daemonset
hostNetwork: true
image: otel/opentelemetry-collector-contrib:0.59.0
image: otel/opentelemetry-collector-contrib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this then defaults to latest, based on the description of the PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

env:
- name: DD_API_KEY
valueFrom:
Expand Down