-
Notifications
You must be signed in to change notification settings - Fork 475
Revert "ci(appsec): fix subprocess flakyness [backport 4.1]" #15788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8dd9c03.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 250 ± 3 ms. The average import time from base is: 252 ± 3 ms. The import time difference between this PR and base is: -2.7 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate revert-15728-backport-15724-to-4.1 (3a2b35a) with baseline 4.1 (0f54a05) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.161µs (SLO: <20.000µs -9.2%) vs baseline: 📈 +21.0% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 14.927µs (SLO: <20.000µs 📉 -25.4%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.547µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -1.4% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 17.898µs (SLO: <30.000µs 📉 -40.3%) vs baseline: -0.7% Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 23.724µs (SLO: <30.000µs 📉 -20.9%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 2.657µs (SLO: <10.000µs 📉 -73.4%) vs baseline: -0.2% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 1.458µs (SLO: <10.000µs 📉 -85.4%) vs baseline: +0.5% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 16.611µs (SLO: <20.000µs 📉 -16.9%) vs baseline: -0.5% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 1.389µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -1.8% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 55.120µs (SLO: <70.000µs 📉 -21.3%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 3.221µs (SLO: <10.000µs 📉 -67.8%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 14.605µs (SLO: <20.000µs 📉 -27.0%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 2.521µs (SLO: <10.000µs 📉 -74.8%) vs baseline: -1.1% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.3% ✅ casefold_aspectTime: ✅ 14.640µs (SLO: <20.000µs 📉 -26.8%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 3.081µs (SLO: <10.000µs 📉 -69.2%) vs baseline: -0.1% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 15.545µs (SLO: <30.000µs 📉 -48.2%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.9% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 18.132µs (SLO: <30.000µs 📉 -39.6%) vs baseline: 📈 +22.3% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 1.471µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -1.0% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 170.785µs (SLO: <200.000µs 📉 -14.6%) vs baseline: -0.1% Memory: ✅ 43.096MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 191.560µs (SLO: <200.000µs -4.2%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 3.738µs (SLO: <10.000µs 📉 -62.6%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 3.122µs (SLO: <10.000µs 📉 -68.8%) vs baseline: -1.2% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.246µs (SLO: <20.000µs 📉 -23.8%) vs baseline: ~same Memory: ✅ 42.880MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 16.818µs (SLO: <20.000µs 📉 -15.9%) vs baseline: -0.8% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.478µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -2.5% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 20.885µs (SLO: <30.000µs 📉 -30.4%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 2.666µs (SLO: <10.000µs 📉 -73.3%) vs baseline: -0.6% Memory: ✅ 42.939MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.774µs (SLO: <30.000µs 📉 -40.8%) vs baseline: -0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 2.386µs (SLO: <10.000µs 📉 -76.1%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 17.590µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 1.834µs (SLO: <10.000µs 📉 -81.7%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 165.902µs (SLO: <200.000µs 📉 -17.0%) vs baseline: -0.3% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 175.140µs (SLO: <200.000µs 📉 -12.4%) vs baseline: +0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 168.016µs (SLO: <200.000µs 📉 -16.0%) vs baseline: -0.2% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.661µs (SLO: <200.000µs 📉 -14.2%) vs baseline: -0.3% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 3.731µs (SLO: <10.000µs 📉 -62.7%) vs baseline: +1.2% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 214.666µs (SLO: <300.000µs 📉 -28.4%) vs baseline: +0.2% Memory: ✅ 43.096MB (SLO: <44.000MB -2.1%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 5.808µs (SLO: <10.000µs 📉 -41.9%) vs baseline: 📈 +11.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.2% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.526µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 23.002µs (SLO: <30.000µs 📉 -23.3%) vs baseline: 📈 +21.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 1.887µs (SLO: <10.000µs 📉 -81.1%) vs baseline: +1.8% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ slice_aspectTime: ✅ 15.963µs (SLO: <20.000µs 📉 -20.2%) vs baseline: +0.5% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.604µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.9% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.3% ✅ stringio_aspectTime: ✅ 53.697µs (SLO: <80.000µs 📉 -32.9%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 3.548µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +0.8% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ strip_aspectTime: ✅ 17.604µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 1.815µs (SLO: <10.000µs 📉 -81.9%) vs baseline: -0.8% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 18.330µs (SLO: <30.000µs 📉 -38.9%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 2.764µs (SLO: <10.000µs 📉 -72.4%) vs baseline: +0.3% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ title_aspectTime: ✅ 18.140µs (SLO: <30.000µs 📉 -39.5%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.000MB 🟡 -0.1%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 2.667µs (SLO: <10.000µs 📉 -73.3%) vs baseline: +1.0% Memory: ✅ 43.136MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 20.286µs (SLO: <30.000µs 📉 -32.4%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.256µs (SLO: <10.000µs 📉 -57.4%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 17.748µs (SLO: <30.000µs 📉 -40.8%) vs baseline: -0.1% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 2.395µs (SLO: <10.000µs 📉 -76.1%) vs baseline: +0.7% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.168µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +22.1% Memory: ✅ 41.307MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 4.301µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -0.1% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.155µs (SLO: <10.000µs 📉 -38.5%) vs baseline: -0.4% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 6.233µs (SLO: <10.000µs 📉 -37.7%) vs baseline: +0.4% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.548µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +2.3% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 3.557µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -0.7% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.822µs (SLO: <10.000µs 📉 -51.8%) vs baseline: -0.5% Memory: ✅ 41.563MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% ✅ ospathsplit_noaspectTime: ✅ 4.955µs (SLO: <10.000µs 📉 -50.5%) vs baseline: -0.5% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.740µs (SLO: <10.000µs 📉 -62.6%) vs baseline: -1.4% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.747µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -1.2% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.654µs (SLO: <10.000µs 📉 -53.5%) vs baseline: +0.7% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 4.685µs (SLO: <10.000µs 📉 -53.2%) vs baseline: ~same Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.362µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +11.6% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 202.027µs (SLO: <220.000µs -8.2%) vs baseline: +1.5% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 1-distribution-metric-1-timesTime: ✅ 3.350µs (SLO: <20.000µs 📉 -83.2%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.298µs (SLO: <230.000µs -5.5%) vs baseline: +0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.199µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.427µs (SLO: <150.000µs -9.0%) vs baseline: +0.2% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.159µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +0.7% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.980µs (SLO: <250.000µs 📉 -13.6%) vs baseline: +0.5% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.282ms (SLO: <22.000ms -7.8%) vs baseline: +0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.296ms (SLO: <2.550ms -10.0%) vs baseline: -0.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.409ms (SLO: <1.550ms -9.1%) vs baseline: +0.8% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.209ms (SLO: <2.550ms 📉 -13.4%) vs baseline: -0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.606µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +0.8% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.4% ✅ flush-100-metricsTime: ✅ 176.218µs (SLO: <250.000µs 📉 -29.5%) vs baseline: +0.6% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.181ms (SLO: <2.500ms 📉 -12.8%) vs baseline: +0.4% Memory: ✅ 35.979MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Reverts #15728