-
Notifications
You must be signed in to change notification settings - Fork 475
Revert "fix(psycopg): fix psycopg3 closed connection patching error [backport 4.1]" #15784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…backport…" This reverts commit 1d9cfeb.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 2 ms. The average import time from base is: 248 ± 2 ms. The import time difference between this PR and base is: -1.01 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate revert-15759-backport-15695-to-4.1 (04f6d62) with baseline 4.1 (9e0eedc) 📈 Performance Regressions (4 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.101µs (SLO: <20.000µs -9.5%) vs baseline: 📈 +20.9% Memory: ✅ 42.920MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 15.017µs (SLO: <20.000µs 📉 -24.9%) vs baseline: -0.2% Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.2% ✅ add_noaspectTime: ✅ 0.545µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.3% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 17.936µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.2% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 23.698µs (SLO: <30.000µs 📉 -21.0%) vs baseline: +0.3% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ bytearray_extend_noaspectTime: ✅ 2.685µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +1.3% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ bytearray_noaspectTime: ✅ 1.461µs (SLO: <10.000µs 📉 -85.4%) vs baseline: +0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% ✅ bytes_aspectTime: ✅ 16.714µs (SLO: <20.000µs 📉 -16.4%) vs baseline: +0.5% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 1.405µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.2% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 54.750µs (SLO: <70.000µs 📉 -21.8%) vs baseline: -0.9% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 3.178µs (SLO: <10.000µs 📉 -68.2%) vs baseline: -1.0% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 14.656µs (SLO: <20.000µs 📉 -26.7%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 2.539µs (SLO: <10.000µs 📉 -74.6%) vs baseline: -1.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ casefold_aspectTime: ✅ 14.575µs (SLO: <20.000µs 📉 -27.1%) vs baseline: -0.6% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.073µs (SLO: <10.000µs 📉 -69.3%) vs baseline: -0.1% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.5% ✅ decode_aspectTime: ✅ 15.614µs (SLO: <30.000µs 📉 -48.0%) vs baseline: -0.2% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 1.585µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -1.0% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 18.354µs (SLO: <30.000µs 📉 -38.8%) vs baseline: 📈 +22.8% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.5% ✅ encode_noaspectTime: ✅ 1.472µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ format_aspectTime: ✅ 171.589µs (SLO: <200.000µs 📉 -14.2%) vs baseline: +0.5% Memory: ✅ 43.116MB (SLO: <43.250MB 🟡 -0.3%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 191.517µs (SLO: <200.000µs -4.2%) vs baseline: +0.1% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 3.749µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +0.5% Memory: ✅ 42.841MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.137µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -0.8% Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.6% ✅ index_aspectTime: ✅ 15.248µs (SLO: <20.000µs 📉 -23.8%) vs baseline: -0.5% Memory: ✅ 42.880MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.5% ✅ index_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.6% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ join_aspectTime: ✅ 16.992µs (SLO: <20.000µs 📉 -15.0%) vs baseline: +0.1% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 1.483µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -1.1% Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 20.667µs (SLO: <30.000µs 📉 -31.1%) vs baseline: -0.9% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.691µs (SLO: <10.000µs 📉 -73.1%) vs baseline: +1.6% Memory: ✅ 42.900MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 17.851µs (SLO: <30.000µs 📉 -40.5%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.442µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +2.3% Memory: ✅ 42.861MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +4.5% ✅ lstrip_aspectTime: ✅ 17.516µs (SLO: <20.000µs 📉 -12.4%) vs baseline: -1.1% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 1.820µs (SLO: <10.000µs 📉 -81.8%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 166.578µs (SLO: <200.000µs 📉 -16.7%) vs baseline: +0.2% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.580µs (SLO: <200.000µs 📉 -12.7%) vs baseline: -0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 168.098µs (SLO: <200.000µs 📉 -16.0%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.930µs (SLO: <200.000µs 📉 -14.0%) vs baseline: ~same Memory: ✅ 43.096MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.695µs (SLO: <10.000µs 📉 -63.0%) vs baseline: +0.4% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 214.266µs (SLO: <300.000µs 📉 -28.6%) vs baseline: -0.3% Memory: ✅ 43.096MB (SLO: <44.000MB -2.1%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 5.150µs (SLO: <10.000µs 📉 -48.5%) vs baseline: -0.8% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.4% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ repr_noaspectTime: ✅ 0.524µs (SLO: <10.000µs 📉 -94.8%) vs baseline: +0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 22.861µs (SLO: <30.000µs 📉 -23.8%) vs baseline: 📈 +19.6% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ rstrip_noaspectTime: ✅ 1.880µs (SLO: <10.000µs 📉 -81.2%) vs baseline: +0.5% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.3% ✅ slice_aspectTime: ✅ 15.987µs (SLO: <20.000µs 📉 -20.1%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 53.837µs (SLO: <80.000µs 📉 -32.7%) vs baseline: -0.3% Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.2% ✅ stringio_noaspectTime: ✅ 3.519µs (SLO: <10.000µs 📉 -64.8%) vs baseline: -1.0% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 17.625µs (SLO: <20.000µs 📉 -11.9%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 1.817µs (SLO: <10.000µs 📉 -81.8%) vs baseline: -0.9% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.3% ✅ swapcase_aspectTime: ✅ 18.405µs (SLO: <30.000µs 📉 -38.7%) vs baseline: -1.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 2.775µs (SLO: <10.000µs 📉 -72.2%) vs baseline: +0.5% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 18.242µs (SLO: <30.000µs 📉 -39.2%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <43.000MB 🟡 ~same) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 2.640µs (SLO: <10.000µs 📉 -73.6%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 20.459µs (SLO: <30.000µs 📉 -31.8%) vs baseline: -0.1% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 4.225µs (SLO: <10.000µs 📉 -57.7%) vs baseline: +0.1% Memory: ✅ 42.841MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 17.927µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 2.408µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +1.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.4% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.154µs (SLO: <10.000µs 📉 -48.5%) vs baseline: 📈 +21.9% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: +0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.103µs (SLO: <10.000µs 📉 -39.0%) vs baseline: -0.9% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 6.209µs (SLO: <10.000µs 📉 -37.9%) vs baseline: -0.8% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.501µs (SLO: <10.000µs 📉 -65.0%) vs baseline: +0.8% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 3.626µs (SLO: <10.000µs 📉 -63.7%) vs baseline: +1.1% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.830µs (SLO: <10.000µs 📉 -51.7%) vs baseline: -0.6% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 4.959µs (SLO: <10.000µs 📉 -50.4%) vs baseline: -0.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.765µs (SLO: <10.000µs 📉 -62.3%) vs baseline: +0.4% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.749µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -1.1% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.626µs (SLO: <10.000µs 📉 -53.7%) vs baseline: +0.5% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.5% ✅ ospathsplitext_noaspectTime: ✅ 4.692µs (SLO: <10.000µs 📉 -53.1%) vs baseline: ~same Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.7% 📈 iastaspectssplit - 12/12✅ rsplit_aspectTime: ✅ 1.710µs (SLO: <10.000µs 📉 -82.9%) vs baseline: 📈 +10.4% Memory: ✅ 41.327MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ rsplit_noaspectTime: ✅ 1.609µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -1.5% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ split_aspectTime: ✅ 1.570µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +0.8% Memory: ✅ 41.307MB (SLO: <43.500MB -5.0%) vs baseline: +4.5% ✅ split_noaspectTime: ✅ 1.627µs (SLO: <10.000µs 📉 -83.7%) vs baseline: +0.6% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ splitlines_aspectTime: ✅ 1.515µs (SLO: <10.000µs 📉 -84.8%) vs baseline: +0.8% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ splitlines_noaspectTime: ✅ 1.570µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +0.4% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.348µs (SLO: <20.000µs 📉 -83.3%) vs baseline: 📈 +10.7% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 1-count-metrics-100-timesTime: ✅ 199.446µs (SLO: <220.000µs -9.3%) vs baseline: -0.2% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.376µs (SLO: <20.000µs 📉 -83.1%) vs baseline: +0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.286µs (SLO: <230.000µs -6.0%) vs baseline: -0.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.193µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.6% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.005µs (SLO: <150.000µs -9.3%) vs baseline: -0.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.157µs (SLO: <20.000µs 📉 -84.2%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 213.972µs (SLO: <250.000µs 📉 -14.4%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.187ms (SLO: <22.000ms -8.2%) vs baseline: -0.9% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.307ms (SLO: <2.550ms -9.5%) vs baseline: +0.1% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.403ms (SLO: <1.550ms -9.5%) vs baseline: -0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.202ms (SLO: <2.550ms 📉 -13.6%) vs baseline: -1.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.612µs (SLO: <20.000µs 📉 -76.9%) vs baseline: -0.7% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +3.9% ✅ flush-100-metricsTime: ✅ 175.134µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +0.5% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.183ms (SLO: <2.500ms 📉 -12.7%) vs baseline: +0.3% Memory: ✅ 36.038MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.1% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Reverts #15759 to minimize changes to 4.1.1